Fixing memory leak of shaperList #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A leak is detected in Engine->shaperList. A simple and safe fix.
elliott-wen
changed the title
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 45.5% 45.51% +<.01%
==========================================
Files 137 137
Lines 59911 59919 +8
==========================================
+ Hits 27263 27271 +8
Misses 32648 32648
Continue to review full report at Codecov.
|
new_native_character returns a complicated data structure, containing a heap allocation object. Should free the heap content before deleting the data structure.
|
Great, thanks! |
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A leak is detected in Engine->shaperList. A simple and safe fix.